Add flag for raising errors on warnings (#1243) #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
feature/werror
branch
3 times, most recently
from
4a514fc to
9041810
Compare
added 3 commits
February 8, 2019 08:00
fix strict mode fix some strict mode asserts add internal WARN_ERROR support and a warn_on_error function make everything that says "warning" go through warn_or_error add --warn-error flag to main.py remove sql_where from tests replace drop-existing with full-refresh in tests (re-)add integration tests for malformed schema/source tests and strict mode
Remove unnecessary is_incremental() from test Fix strict mode type check
beckjake
force-pushed
the
feature/werror
branch
from
11bc183 to
90497b1
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1243
Fixes #1279
fixes strict mode + related asserts
adds internal WARN_ERROR support and a warn_on_error function
makes everything that says "warning" go through warn_or_error
adds --warn-error flag to main.py
removes sql_where from tests
replaces drop-existing with full-refresh in tests
(re-)adds integration tests for malformed schema/source tests and strict mode