Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Widen botocore/boto3 requirements (#1234) #1297

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

beckjake
Copy link
Contributor

Fixes #1234

In the snowflake adapter, increase the minimum snowflake-connector-python to 1.6.12, that was the most recent boto3/botocore requirements change.

Then in the redshift plugin, set the boto3/botocore maximum versions to match the snowflake plugin's dependencies' upper bound. Currently, that includes the most recent versions of boto3/botocore.

Remove botocore/boto3 restrictions on the snowflake plugin
Increase minimum snowflake-connector-python to 1.6.12
 - 1.6.12 is the most recent boto3/botocore requirements change
Increase the upper bounds on boto3/botocre to match the redshift plugin
 - they match the upper bounds of snowflake-connector-python 1.6.12
Copy link
Member

@cmcarthur cmcarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. approved

@beckjake beckjake merged commit cda365f into dev/stephen-girard Feb 14, 2019
@beckjake beckjake deleted the fix/widen-boto3-restrictions branch February 14, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants