Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the check archive strategy (#706) #1394

Merged
merged 4 commits into from
Apr 12, 2019

Conversation

beckjake
Copy link
Contributor

Fixes #706

This is based on the archive-blocks PR branch (#1361)

TODO: Make the tests faster, probably by combining more of them
TODO: We probably need to cache column information about relations where we can, we make a ton of redundant calls on that front.

Jacob Beck added 3 commits April 10, 2019 11:36
Contracts: some anyOf shenanigans to add support for check_cols
Macros: split apart archive selection, probably too much copy+paste
Legacy: Archive configs now include a "timestamp" strategy when parsed from dbt_project.yml
Add integration tests
@beckjake beckjake force-pushed the feature/check-cols-strategy branch from 56d49f8 to 1eb5003 Compare April 11, 2019 22:27
@beckjake
Copy link
Contributor Author

Merging this into the parent branch, we can do them all in one PR...

@beckjake beckjake marked this pull request as ready for review April 12, 2019 14:35
@beckjake beckjake merged commit bf0f909 into feature/archive-blocks-as-regex Apr 12, 2019
@beckjake beckjake deleted the feature/check-cols-strategy branch April 12, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant