Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake create or replace #1409

Merged
merged 34 commits into from
May 15, 2019
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
9772c1c
Adding incremental logic to Snowflake plugins
Feb 18, 2019
56801f9
Adding changes based on Drew's recommendations
Mar 2, 2019
38254a8
make create or replace snowflake macro
bastienboutonnet Apr 16, 2019
9222c79
implement create or replace in table mater
bastienboutonnet Apr 16, 2019
a35ad18
implement insert when no unique key and full refresh solution
bastienboutonnet Apr 20, 2019
2d5525e
add some logging
bastienboutonnet Apr 20, 2019
6a104c1
test
bastienboutonnet Apr 20, 2019
d168bdd
Merge branch 'snowflake_create_or_replace' of github.com:bastienbouto…
bastienboutonnet Apr 20, 2019
91d869e
revert test
bastienboutonnet Apr 20, 2019
fb26ce5
Merge branch 'snowflake_create_or_replace' of github.com:bastienbouto…
bastienboutonnet Apr 20, 2019
dacce7c
fix insert cols call and temp workaround call of snowflake
bastienboutonnet Apr 21, 2019
54c02ef
some logging and temp call workaround
bastienboutonnet Apr 21, 2019
2830b6a
make default create or replace macro to allow snowflake adapter pick …
bastienboutonnet Apr 22, 2019
95c9f76
remove snowflake__ direct call in incremental
bastienboutonnet Apr 22, 2019
0433369
remove testing logging messages
bastienboutonnet Apr 22, 2019
e83edd3
fixme/todo regarding non destructive flag
bastienboutonnet Apr 22, 2019
9591b86
(PR fdbk) rm extra macro
bastienboutonnet Apr 26, 2019
f99efbf
remove references to temp and backup relations
bastienboutonnet Apr 26, 2019
5c1c588
more explicit comments and quick formatting
bastienboutonnet Apr 26, 2019
43a9db5
quick todo marker
bastienboutonnet Apr 27, 2019
3ab8238
Merge branch 'dev/wilt-chamberlain' into snowflake_create_or_replace
bastienboutonnet Apr 27, 2019
4f62978
Revert "Merge branch 'dev/wilt-chamberlain' into snowflake_create_or_…
bastienboutonnet Apr 27, 2019
08820a2
fixing my jetlagged introduced bugs
bastienboutonnet Apr 27, 2019
0432c1d
conflic resolve
bastienboutonnet Apr 27, 2019
90f8e0b
Revert "Revert "Merge branch 'dev/wilt-chamberlain' into snowflake_cr…
bastienboutonnet Apr 27, 2019
afe236d
cleaning up some commented out stuff
bastienboutonnet Apr 27, 2019
8af7984
remove non-destructive logic
bastienboutonnet Apr 28, 2019
85eac05
cleaner select
bastienboutonnet Apr 28, 2019
3ef519d
todo and comments clean up
bastienboutonnet Apr 28, 2019
7a2279e
move unique key workaround to snowflake macro
bastienboutonnet Apr 28, 2019
3a7dcd9
Merge branch 'dev/wilt-chamberlain' into snowflake_create_or_replace
drewbanin Apr 30, 2019
1f97fe4
Merge branch 'dev/wilt-chamberlain' into snowflake_create_or_replace
drewbanin Apr 30, 2019
8d74550
fix tests
drewbanin May 10, 2019
90abc2d
(closes #1455) Qualify Snowflake temp tables with a database and schema
drewbanin May 13, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
{{ adapter.drop_relation(intermediate_relation) }}

-- setup: if the target relation already exists, truncate or drop it (if it's a view)
{# TODO: Would like to check this. New materialsiation makes these tests a bit moot. We should
bastienboutonnet marked this conversation as resolved.
Show resolved Hide resolved
be able to deprecate non-destructive flag all together here. #}
{% if non_destructive_mode -%}
bastienboutonnet marked this conversation as resolved.
Show resolved Hide resolved
{% if exists_as_table -%}
--noop we can do away with this step all together since the table can be replaced in Snowflake.
Expand Down