Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ilike instead of = for database when listing schemas (#1411) #1412

Merged
merged 1 commit into from
Apr 24, 2019
Merged

use ilike instead of = for database when listing schemas (#1411) #1412

merged 1 commit into from
Apr 24, 2019
+1 −1

Conversation

beckjake
Copy link
Contributor

Fixes #1411

I am actually not really sure if that where clause is useful at all, given that information schema queries are database-specific, but this should be less wrong, at least.

drewbanin
drewbanin approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ha, i didn't recognize that this was a filter on the catalog name.... yeah.... we could equivalently just remove that filter altogether.

This looks good though, ship it when the tests pass!

@beckjake beckjake marked this pull request as ready for review April 24, 2019 16:58
@beckjake beckjake merged commit ad1fcbe into dev/0.13.1 Apr 24, 2019
@beckjake beckjake deleted the fix/insensitive-list-schemas branch April 24, 2019 18:02
@beckjake beckjake mentioned this pull request Apr 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beckjake @drewbanin