Refactor node selection #1490
Merged
Refactor node selection #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
May 30, 2019
| package_names = get_package_names(graph) | ||
| for node, real_node in self.parsed_nodes(graph): | ||
| qualified_name = selector.split(".") | ||
| package_names = {node.split(".")[1] for node in included_nodes} |
There was a problem hiding this comment.
Is the package name always the second item in the unique_id?
There was a problem hiding this comment.
Yup! It's not true for docs, but they don't participate here.
beckjake
changed the base branch from
dev/wilt-chamberlain
to
dev/louisa-may-alcott
beckjake
force-pushed
the
refactor/node-selector-separated
branch
from
ff787b2
to
da97aa0
Compare
beckjake
force-pushed
the
refactor/node-selector-separated
branch
from
da97aa0
to
2b89c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor node selection to split the part that knows about graphs (and therefore children/parents) from the part that only knows about the manifest (names and globs).
This is part of the groundwork for #1212