Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render source_description fields in sources (#1484) #1494

Merged
merged 1 commit into from
May 30, 2019
Merged

Render source_description fields in sources (#1484) #1494

merged 1 commit into from
May 30, 2019

Conversation

beckjake
Copy link
Contributor

Fixes #1484

We just never rendered this field, and even had a test asserting we never rendered it 🤦‍♂

@beckjake beckjake requested a review from drewbanin May 30, 2019 16:56
drewbanin
drewbanin approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the tests pass!

@beckjake beckjake merged commit 00cbe3e into dev/wilt-chamberlain May 30, 2019
@beckjake beckjake deleted the fix/render-descriptions-properly branch May 30, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Description returns jinja as a string when trying to render Markdown
2 participants
@beckjake @drewbanin