Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for snapshots, make the argument "--select", not "--models" (#1517) #1520

Merged
merged 2 commits into from
Jun 12, 2019
Merged

for snapshots, make the argument "--select", not "--models" (#1517) #1520

merged 2 commits into from
Jun 12, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Jun 7, 2019

Fixes #1512

@beckjake beckjake changed the title for archives/snapshots, make the argument "--select", not "--models" (#1517) for snapshots, make the argument "--select", not "--models" (#1517) Jun 7, 2019
drewbanin
drewbanin approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this, LGTM!

@beckjake beckjake force-pushed the feature/rename-models-to-select branch from b1b216d to 4a10c8d Compare June 12, 2019 21:39
@beckjake beckjake merged commit a554b38 into dev/wilt-chamberlain Jun 12, 2019
@beckjake beckjake deleted the feature/rename-models-to-select branch June 12, 2019 22:14
@beckjake beckjake mentioned this pull request Jun 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Wilt Chamberlain] Add severity configs to custom data tests
2 participants
@beckjake @drewbanin