Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Snowflake clustering #1591
Implement Snowflake clustering #1591
Changes from 15 commits
70694e3
aef7866
e60280c
aaa0127
9e36ebd
4e635e3
adb1df0
32540a1
8fbd792
2bc59e0
1cabf43
fe0be06
b4fbf7c
fd58297
c5c1946
954fed0
ba04a87
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did one last scan here - I think this won't work properly if
cluster_by_keys
is provided as a list. If that happens, then the code in this branch won't be executed. I think we should move this line outside of the if block here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh dear... good catch! I can certainly fix that! BUT I just realised to cleaned my fork so I don't actually know how to can edit this on my side. I had to fork dbt again as we were experimenting and forgot this was still pending. Do you know what would be the best way to go? I could probably fork again, or do a new PR but then we'd loose the trace of our discussion (although we could refer to it even if the PR is closed). Let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh dear indeed! I've never seen this before!
There's a cool thing you can do on GitHub - if you add
.patch
to the end of a PR url, you'll get a "patch" for the change. I think you should be able to make a clean branch off ofdev/0.14.1
, then do something like:If git says that it can't apply the patch, you can try applying the patch from the commit
9e36ebd
.Let me know how it goes!