Fix for unicode chars in seed files #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
fix/seed-nonascii-chars
branch
from
ee17999
to
8fd768e
Compare
|
Works great - thanks for cleaning this one up @beckjake! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First cut at fixing an 0.14.0 regression that prevented
seedfrom working when csv files contain non-ascii characters. closes #1632@beckjake I took a quick stab at this -- my implementation differed from the one that you originally suggested! I tried opening the file in
Urbmode on py2, but that didn't appear to work. I don't know that the implementation I'm using here is a good one, but wanted to throw this out as a first attempt.