Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add configs to ParsedNodes before generating a schema/alias #1701

Merged
merged 3 commits into from
Aug 27, 2019
Merged

add configs to ParsedNodes before generating a schema/alias #1701

merged 3 commits into from
Aug 27, 2019
+79 −9

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Aug 27, 2019 •
edited
Loading

fixes #1700

Moves the setting of the tags and config properties of the node to before the execution of generate_schema_name and generate_alias_name.

@cla-bot cla-bot bot added the cla:yes label Aug 27, 2019
beckjake
beckjake approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drewbanin drewbanin merged commit c002858 into dev/0.14.1 Aug 27, 2019
@drewbanin drewbanin deleted the feature/expose-config-in-generation-macros branch August 27, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckjake beckjake beckjake approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide user-supplied configs to ParsedNodes before generating alias/schema names
2 participants
@drewbanin @beckjake