Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs generate RPC task (#1781) #1801

Merged
merged 2 commits into from
Oct 7, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Oct 2, 2019

Fixes #1781

Implement docs generate for the RPC task. I went with docs.generate for the RPC call name, since . is allowed and it seems like a nice namespace separator. That way we can do dbt source snapshot-freshness -> source.snapshot-freshness in the future, and the mapping is reasonably straightforward.

@cla-bot cla-bot bot added the cla:yes label Oct 2, 2019
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look to me like the docs.generate task creates a manifest.json after compilation -- can you double check that and add a test for it?

Otherwise, this LGTM

@beckjake
Copy link
Contributor Author

beckjake commented Oct 7, 2019

It doesn't look to me like the docs.generate task creates a manifest.json after compilation -- can you double check that and add a test for it?

ok. the issue is that we do generate a manifest.json but only during the RPC server's compilation, not during catalog generation.

@beckjake beckjake force-pushed the feature/add-docs-generate-rpc branch from 4dd0d9d to 02feb69 Compare October 7, 2019 13:38
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great -- ship it!

@beckjake beckjake merged commit 8194fd4 into dev/louisa-may-alcott Oct 7, 2019
@beckjake beckjake deleted the feature/add-docs-generate-rpc branch October 7, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support docs generation in the rpc server
2 participants