add a formal search order for materializations, tests (#1962) #1976
+451
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
fix/override-materializations
branch
from
93bc104
to
1b0d635
Compare
drewbanin
approved these changes
Dec 9, 2019
| locality: Locality | ||
| macro: ParsedMacro | ||
|
|
||
| def __eq__(self, other): |
There was a problem hiding this comment.
Should this also check the name of the materialization? Or is that better handled in the caller?
There was a problem hiding this comment.
Two candidates that are "the same" could have different names - in fact if they have different specificity they will by definition have different names.
Whenever we are comparing candidates, we know they're all the same base macro name in the end - that's why we're sorting them, to decide which of the matching macros to pick. So we can just ignore that here, the type only exists for list.sort().
There was a problem hiding this comment.
makes sense to me! ship it :)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1962
I've added some integration tests - not sure if there should be more covering the other possible behaviors, but I think this is reasonably comprehensive.