Fix bigquery catalog queries with nonexistent schemas (#1984) #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Dec 13, 2019
| {% for information_schema in information_schemas %} | ||
| {%- if (information_schemas | length) == 0 -%} | ||
| {# Hopefully nothing cares about the columns we return when there are no rows #} | ||
| {%- set query = "select 1 as id limit 0" -%} |
There was a problem hiding this comment.
Can we return(none) here and make the get_catalog method error with a sensible message?
There was a problem hiding this comment.
Should it really error instead of the catalog just being empty? As it is this works, it just generates an empty catalog.
There was a problem hiding this comment.
oh, ok, that's great. Ship this as-is :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1984
Fix bigquery catalog queries when schemas don't exist, by filtering them out. There's a minor hack in the catalog macro to stub out the query in the event that there are no valid information schemas to query.