Fix source test arg rendering (#2114) #2150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2114
Description
With this PR, dbt now gives an error on tests in sources of the schema.yml section.
To get to the ultimately desired behavior, see #2149 - to be resolved in 0.17.0, probably.
This is a breaking change! We used to render args in the schema-yaml-rendering-context, which was incorrect and didn't match the behavior in models.
I'm left with the uncomfortable feeling that someone out there is using
{{ invocation_id }}
or{{ run_started_at }}
in parameters to their tests (why else would we do this?).We could alternatively generate a full runtime context and re-render wrapped SQL. I don't think that's the worst idea of all time, but it might be slower. Definitely a hack!
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.