Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UnsetProfileConfig.from_args to use args.project_dir if passed #2339

Merged
merged 6 commits into from
Apr 17, 2020
Merged

Update UnsetProfileConfig.from_args to use args.project_dir if passed #2339

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a376d65
Update UnsetProfileConfig.from_args to use args.project_dir if passed
nickwu241 Apr 17, 2020
72d2cab
Update UnsetProfileConfig.from_args docstring
nickwu241 Apr 17, 2020
66f9ee0
Updatet CHANGELOD.md with dbt deps fix
nickwu241 Apr 17, 2020
dda9289
Update core/dbt/config/runtime.py
nickwu241 Apr 17, 2020
d5f5095
Add test for running simple dbt commands with --project-dir arg
nickwu241 Apr 17, 2020
2a0f69a
Update test to change out of dir that will be deleted
nickwu241 Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- Return error message when profile is empty in profiles.yml. ([#2292](https://github.com/fishtown-analytics/dbt/issues/2292), [#2297](https://github.com/fishtown-analytics/dbt/pull/2297))
- Fix skipped node count in stdout at the end of a run ([#2095](https://github.com/fishtown-analytics/dbt/issues/2095), [#2310](https://github.com/fishtown-analytics/dbt/pull/2310))
- Fix an issue where BigQuery incorrectly used a relation's quote policy as the basis for the information schema's include policy, instead of the relation's include policy. ([#2188](https://github.com/fishtown-analytics/dbt/issues/2188), [#2325](https://github.com/fishtown-analytics/dbt/pull/2325))
- Fix "dbt deps" command so it respects the "--project-dir" arg if specified. ([#2338](https://github.com/fishtown-analytics/dbt/issues/2338), [#2339](https://github.com/fishtown-analytics/dbt/issues/2339))

### Under the hood
- Added more tests for source inheritance ([#2264](https://github.com/fishtown-analytics/dbt/issues/2264), [#2291](https://github.com/fishtown-analytics/dbt/pull/2291))
Expand All @@ -33,6 +34,7 @@ Contributors:
- [@jeremyyeo](https://github.com/jeremyyeo) [#2259](https://github.com/fishtown-analytics/dbt/pull/2259)
- [@rodrigodelmonte](https://github.com/rodrigodelmonte) [#2298](https://github.com/fishtown-analytics/dbt/pull/2298)
- [@sumanau7](https://github.com/sumanau7) ([#2279](https://github.com/fishtown-analytics/dbt/pull/2279), [#2263](https://github.com/fishtown-analytics/dbt/pull/2263), [#2297](https://github.com/fishtown-analytics/dbt/pull/2297))
- [@nickwu241](https://github.com/nickwu241) [#2339](https://github.com/fishtown-analytics/dbt/issues/2339)

## dbt 0.16.1 (April 14, 2020)

Expand Down
9 changes: 5 additions & 4 deletions core/dbt/config/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,17 +297,18 @@ def from_parts(

@classmethod
def from_args(cls: Type[RuntimeConfig], args: Any) -> 'RuntimeConfig':
"""Given arguments, read in dbt_project.yml from the current directory,
read in packages.yml if it exists, and use them to find the profile to
load.
"""Given arguments, read in dbt_project.yml from the arg --project-dir
or current directory if not provided, read in packages.yml if it exists,
and use them to find the profile to load.
nickwu241 marked this conversation as resolved.
Show resolved Hide resolved

:param args: The arguments as parsed from the cli.
:raises DbtProjectError: If the project is invalid or missing.
:raises DbtProfileError: If the profile is invalid or missing.
:raises ValidationException: If the cli variables are invalid.
"""
# profile_name from the project
partial = Project.partial_load(os.getcwd())
project_root = args.project_dir if args.project_dir else os.getcwd()
partial = Project.partial_load(project_root)

# build the profile using the base renderer and the one fact we know
cli_vars: Dict[str, Any] = parse_cli_vars(getattr(args, 'vars', '{}'))
Expand Down