-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker use ENTRYPOINT dbt #2471
Docker use ENTRYPOINT dbt #2471
Conversation
…e-sources-crash Fix duplicate sources crash
…lfast-msg Fix typo in failfast msg
Fix tests to run on macos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dmateusp, thanks for this PR!
I love this change, but can we just change the script and leave these existing Dockerfiles alone?
I think it's important that they match what's on the docker repository as a historical record (even if it's a historical record of me writing bad code 😆).
Please also add a changelog entry for yourself with a link to this contribution!
I'll plan on back-porting this to dev/octavius-catto
so it can make it in to 0.17.0, unless you want to rebase and change the target repository yourself.
Sure no problems! I was wondering if I should change the Dockerfiles, the reason I did is because as far as I can tell they're not usable if the CMD or ENTRYPOINT is overwritten right now. I will remove those changes Sure I will update the ChangeLog I can rebase it! any reason |
2049dc8
to
e9daff7
Compare
We're in the habit of naming minor versions after famous Philadelphians :) |
resolves #2470
Description
Change the entrypoint to be able to pass arguments and use DBT as it is used outside the container
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.