Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker use ENTRYPOINT dbt #2471

Conversation

dmateusp
Copy link
Contributor

resolves #2470

Description

Change the entrypoint to be able to pass arguments and use DBT as it is used outside the container

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label May 20, 2020
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dmateusp, thanks for this PR!
I love this change, but can we just change the script and leave these existing Dockerfiles alone?

I think it's important that they match what's on the docker repository as a historical record (even if it's a historical record of me writing bad code 😆).

Please also add a changelog entry for yourself with a link to this contribution!
I'll plan on back-porting this to dev/octavius-catto so it can make it in to 0.17.0, unless you want to rebase and change the target repository yourself.

@dmateusp
Copy link
Contributor Author

Sure no problems! I was wondering if I should change the Dockerfiles, the reason I did is because as far as I can tell they're not usable if the CMD or ENTRYPOINT is overwritten right now. I will remove those changes

Sure I will update the ChangeLog

I can rebase it! any reason dev/marian-anderson is the default instead of dev/octavius-catto ? I actually don't know what those names refer to. Are they named releases?

@dmateusp dmateusp force-pushed the dmateusp/fix_docker_entrypoints branch from 2049dc8 to e9daff7 Compare May 20, 2020 14:15
@dmateusp dmateusp closed this May 20, 2020
@dmateusp dmateusp mentioned this pull request May 20, 2020
4 tasks
@jtcohen6
Copy link
Contributor

jtcohen6 commented May 20, 2020

any reason dev/marian-anderson is the default instead of dev/octavius-catto ? I actually don't know what those names refer to. Are they named releases?

We're in the habit of naming minor versions after famous Philadelphians :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.17.0rc1] Broken Docker image entrypoint
3 participants