Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: respect config options in dbt_project.yml #255

Merged
merged 13 commits into from
Dec 28, 2016
Merged

bugfix: respect config options in dbt_project.yml #255

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4811888
bugfix: respect config options in dbt_project.yml
Dec 23, 2016
cd531aa
unit test harness
Dec 23, 2016
29a31bd
remove now-unused test runner
Dec 23, 2016
7912de0
Merge branch 'development' of github.com:analyst-collective/dbt into …
Dec 23, 2016
6ae353c
add newline to the end of .gitignore
Dec 23, 2016
16418ae
create a working windows test directory
Dec 23, 2016
1aad991
fix CHANGELOG.mg pointer
Dec 23, 2016
9afcb79
update wording of changelog entry
Dec 23, 2016
05ab471
solve KeyError when config is not set
Dec 24, 2016
fceb38a
add test for existing file, with no config key (catch KeyError from l…
Dec 24, 2016
1a4f607
merge development
Dec 24, 2016
50d2726
remove undefined default_profiles_dir
Dec 24, 2016
5db3c99
remove None default, add a TODO around argument validation
Dec 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions dbt/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@


def read_config(profiles_dir=None):
if profiles_dir is None:
profiles_dir = default_profiles_dir

path = os.path.join(profiles_dir, 'profiles.yml')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think passing None to os.path.join causes a TypeError.

Previously, this file was assumed to be located at ~/.dbt/profiles.yml. We should either remove the default value for profiles_dir and insist that the caller passes a value, or we should coalesce None to the default filepath

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good call. since read_config is part of the private API of this namespace, and calls have to go through send_anonymous_usage_stats, i just removed the default None value.


if os.path.isfile(path):
Expand Down