Fix: dbt clean without profile

CHANGELOG.md

@@ -2,7 +2,8 @@
 
 
 ### Fixes
-- fast-fail option with adapters that don't support cancelling queries will now passthrough the original error messages ([#2644](https://github.com/fishtown-analytics/dbt/issues/2644))
+- fast-fail option with adapters that don't support cancelling queries will now passthrough the original error messages ([#2644](https://github.com/fishtown-analytics/dbt/issues/2644), [#2646](https://github.com/fishtown-analytics/dbt/pull/2646))
+- `dbt clean` no longer requires a profile ([#2620](https://github.com/fishtown-analytics/dbt/issues/2620), [#2649](https://github.com/fishtown-analytics/dbt/pull/2649))
 
 Contributors:
  - [@joshpeng-quibi](https://github.com/joshpeng-quibi) ([#2646](https://github.com/fishtown-analytics/dbt/pull/2646))

azure-pipelines.yml

@@ -37,13 +37,13 @@ jobs:
       Set-Service -InputObject $serviceName -StartupType Automatic
       Start-Service -InputObject $serviceName
 
-      createdb.exe -U postgres dbt
-      psql.exe  -U postgres -c "CREATE ROLE root WITH PASSWORD 'password';"
-      psql.exe  -U postgres -c "ALTER ROLE root WITH LOGIN;"
-      psql.exe  -U postgres -c "GRANT CREATE, CONNECT ON DATABASE dbt TO root WITH GRANT OPTION;"
-      psql.exe  -U postgres -c "CREATE ROLE noaccess WITH PASSWORD 'password' NOSUPERUSER;"
-      psql.exe  -U postgres -c "ALTER ROLE noaccess WITH LOGIN;"
-      psql.exe  -U postgres -c "GRANT CONNECT ON DATABASE dbt TO noaccess;"
+      & $env:PGBIN\createdb.exe -U postgres dbt
+      & $env:PGBIN\psql.exe  -U postgres -c "CREATE ROLE root WITH PASSWORD 'password';"
+      & $env:PGBIN\psql.exe  -U postgres -c "ALTER ROLE root WITH LOGIN;"
+      & $env:PGBIN\psql.exe  -U postgres -c "GRANT CREATE, CONNECT ON DATABASE dbt TO root WITH GRANT OPTION;"
+      & $env:PGBIN\psql.exe  -U postgres -c "CREATE ROLE noaccess WITH PASSWORD 'password' NOSUPERUSER;"
+      & $env:PGBIN\psql.exe  -U postgres -c "ALTER ROLE noaccess WITH LOGIN;"
+      & $env:PGBIN\psql.exe  -U postgres -c "GRANT CONNECT ON DATABASE dbt TO noaccess;"
     displayName: Install postgresql and set up database
 
   - task: UsePythonVersion@0

core/dbt/task/clean.py

@@ -2,11 +2,13 @@
 import os
 import shutil
 
-from dbt.task.base import ConfiguredTask
+from dbt.task.base import BaseTask
 from dbt.logger import GLOBAL_LOGGER as logger
+from dbt.config import UnsetProfileConfig
 
 
-class CleanTask(ConfiguredTask):
+class CleanTask(BaseTask):
+    ConfigType = UnsetProfileConfig
 
     def __is_project_path(self, path):
         proj_path = os.path.abspath('.')

test/integration/006_simple_dependency_test/test_simple_dependency.py

@@ -1,5 +1,4 @@
 import os
-import shutil
 import tempfile
 from test.integration.base import DBTIntegrationTest, use_profile
 from dbt.exceptions import CompilationException
@@ -34,6 +33,9 @@ def packages_config(self):
     def run_deps(self):
         return self.run_dbt(["deps"])
 
+    def run_clean(self):
+        return self.run_dbt(['clean'])
+
     @use_profile('postgres')
     def test_postgres_simple_dependency(self):
         self.run_deps()
@@ -56,6 +58,10 @@ def test_postgres_simple_dependency(self):
         self.assertTablesEqual("seed", "view_model")
         self.assertTablesEqual("seed", "incremental")
 
+        assert os.path.exists('target')
+        self.run_clean()
+        assert not os.path.exists('target')
+
     @use_profile('postgres')
     def test_postgres_simple_dependency_with_models(self):
         self.run_deps()
@@ -73,6 +79,10 @@ def test_postgres_simple_dependency_with_models(self):
         self.assertEqual(created_models['view_model'], 'view')
         self.assertEqual(created_models['view_summary'], 'view')
 
+        assert os.path.exists('target')
+        self.run_clean()
+        assert not os.path.exists('target')
+
 
 class TestSimpleDependencyUnpinned(DBTIntegrationTest):
     def setUp(self):
@@ -234,9 +244,11 @@ def test_postgres_empty_models_not_compiled_in_dependencies(self):
 
 class TestSimpleDependencyNoProfile(TestSimpleDependency):
     def run_deps(self):
-        tmpdir = tempfile.mkdtemp()
-        try:
+        with tempfile.TemporaryDirectory() as tmpdir:
             result = self.run_dbt(["deps", "--profiles-dir", tmpdir])
-        finally:
-            shutil.rmtree(tmpdir)
+        return result
+
+    def run_clean(self):
+        with tempfile.TemporaryDirectory() as tmpdir:
+            result = self.run_dbt(["clean", "--profiles-dir", tmpdir])
         return result