Fix: close connections after use

CHANGELOG.md

@@ -1,13 +1,19 @@
 ## dbt 0.17.2 (Release TBD)
 
 
+### Breaking changes (for plugins)
+- The `release` argument to adapter.execute_macro no longer has any effect. It will be removed in a future release of dbt (likely 0.18.0) ([#2650](https://github.com/fishtown-analytics/dbt/pull/2650))
+
+
 ### Fixes
 - fast-fail option with adapters that don't support cancelling queries will now passthrough the original error messages ([#2644](https://github.com/fishtown-analytics/dbt/issues/2644), [#2646](https://github.com/fishtown-analytics/dbt/pull/2646))
 - `dbt clean` no longer requires a profile ([#2620](https://github.com/fishtown-analytics/dbt/issues/2620), [#2649](https://github.com/fishtown-analytics/dbt/pull/2649))
 - Close all connections so snowflake's keepalive thread will exit. ([#2645](https://github.com/fishtown-analytics/dbt/issues/2645), [#2650](https://github.com/fishtown-analytics/dbt/pull/2650))
 
 Contributors:
  - [@joshpeng-quibi](https://github.com/joshpeng-quibi) ([#2646](https://github.com/fishtown-analytics/dbt/pull/2646))
+
+
 ## dbt 0.17.2b1 (July 21, 2020)
 
 

core/dbt/adapters/base/impl.py

@@ -934,8 +934,10 @@ def execute_macro(
             execution context.
         :param kwargs: An optional dict of keyword args used to pass to the
             macro.
-        :param release: If True, release the connection after executing.
+        :param release: Ignored.
         """
+        if release is not False:
+            deprecations.warn('execute-macro-release')
         if kwargs is None:
             kwargs = {}
         if context_override is None:
@@ -971,11 +973,7 @@ def execute_macro(
         macro_function = MacroGenerator(macro, macro_context)
 
         with self.connections.exception_handler(f'macro {macro_name}'):
-            try:
-                result = macro_function(**kwargs)
-            finally:
-                if release:
-                    self.release_connection()
+            result = macro_function(**kwargs)
         return result
 
     @classmethod
@@ -1007,7 +1005,6 @@ def _get_one_catalog(
         table = self.execute_macro(
             GET_CATALOG_MACRO_NAME,
             kwargs=kwargs,
-            release=False,
             # pass in the full manifest so we get any local project
             # overrides
             manifest=manifest,
@@ -1063,7 +1060,6 @@ def calculate_freshness(
         table = self.execute_macro(
             FRESHNESS_MACRO_NAME,
             kwargs=kwargs,
-            release=False,
             manifest=manifest
         )
         # now we have a 1-row table of the maximum `loaded_at_field` value and

core/dbt/deprecations.py

@@ -108,6 +108,15 @@ class DbtProjectYamlDeprecation(DBTDeprecation):
     '''
 
 
+class ExecuteMacrosReleaseDeprecation(DBTDeprecation):
+    _name = 'execute-macro-release'
+    _description = '''\
+    The "release" argument to execute_macro is now ignored, and will be removed
+    in a future relase of dbt. At that time, providing a `release` argument
+    will result in an error.
+    '''
+
+
 _adapter_renamed_description = """\
 The adapter function `adapter.{old_name}` is deprecated and will be removed in
 a future release of dbt. Please use `adapter.{new_name}` instead.
@@ -151,6 +160,7 @@ def warn(name, *args, **kwargs):
     ColumnQuotingDeprecation(),
     ModelsKeyNonModelDeprecation(),
     DbtProjectYamlDeprecation(),
+    ExecuteMacrosReleaseDeprecation(),
 ]
 
 deprecations: Dict[str, DBTDeprecation] = {

test/rpc/conftest.py

@@ -35,12 +35,11 @@ def pytest_collection_modifyitems(config, items):
 
 
 def pytest_configure(config):
-    config.addinivalue_line('markers', 'supported(: Marks postgres-only tests')
+    # the '(plugin, ...)' part isn't really important: any positional arguments
+    # to `pytest.mark.supported` will be consumed as plugin names.
+    helptxt = 'Marks supported test types ("postgres", "snowflake", "any")'
     config.addinivalue_line(
-        'markers', 'snowflake: Mark snowflake-only tests'
-    )
-    config.addinivalue_line(
-        'markers', 'any: Mark '
+        'markers', f'supported(plugin, ...): {helptxt}'
     )