Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove double underscore from cte prefix ephemeral #2662

Closed
wants to merge 1 commit into from
Closed

remove double underscore from cte prefix ephemeral #2662

wants to merge 1 commit into from

Conversation

tglunde
Copy link

@tglunde tglunde commented Jul 29, 2020

resolves #2660

Descriptione-->

Basically just removed double underscore from ephemeral CTE prefix in order to support dbt-exasol adapter.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jul 29, 2020
@jtcohen6
Copy link
Contributor

@tglunde We'd like to resolve #2660 differently, by moving add_ephemeral_model_prefix into an adapter method, and ensuring that we always use that adapter method instead of hard-coding __dbt__CTE__ephemeral. I'm hoping to include that change in v0.18.0.

@jtcohen6
Copy link
Contributor

Closed by #2712

@jtcohen6 jtcohen6 closed this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove double underscore in epheremal model generated CTE (__dbt__CTE__...)
2 participants
@tglunde @jtcohen6