Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if a snowflake column exists before altering its comment #3149

Merged
merged 9 commits into from
May 13, 2021
Merged

Check if a snowflake column exists before altering its comment #3149

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d4e6d79
Check if column exists when altering column comments in snowflake
Mar 5, 2021
69861b9
Merge remote-tracking branch 'origin/develop' into fix/column-comment…
May 6, 2021
6f2ef06
Add new test class for persist docs models with missing columns
May 12, 2021
7cfd2b3
Parallel run all integration tests after unit (#3328)
jtcohen6 May 11, 2021
1127ad6
don't clobber default args
May 11, 2021
695c138
update changelog
May 12, 2021
3f18907
Update changelog for PR #3149
May 12, 2021
0c15a9a
Pull in upstream changes
May 13, 2021
4af6c81
Merge branch 'develop' into fix/column-comment-if-exists
jtcohen6 May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions plugins/snowflake/dbt/include/snowflake/macros/adapters.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,8 @@


{% macro snowflake__alter_column_comment(relation, column_dict) -%}
alter {{ relation.type }} {{ relation }} alter
{% for column_name in column_dict %}
{{ adapter.quote(column_name) if column_dict[column_name]['quote'] else column_name }} COMMENT $${{ column_dict[column_name]['description'] | replace('$', '[$]') }}$$ {{ ',' if not loop.last else ';' }}
comment if exists on column {{ relation }}.{{ adapter.quote(column_name) if column_dict[column_name]['quote'] else column_name }} is $${{ column_dict[column_name]['description'] | replace('$', '[$]') }}$$;
{% endfor %}
{% endmacro %}

Expand Down