Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow dataclasses >= 0.6, < 0.9 #3151

Merged
merged 5 commits into from
Mar 9, 2021
Merged

chore: allow dataclasses >= 0.6, < 0.9 #3151

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84155fd
point hologram install to my fork and up dataclasses
bastienboutonnet Mar 8, 2021
034a44e
fix git install link
bastienboutonnet Mar 8, 2021
280f561
bump hologram to 0.0.14
bastienboutonnet Mar 8, 2021
af77831
relax dependency on dataclasses requirements as in hologram
bastienboutonnet Mar 9, 2021
34174ab
add changelog entry
bastienboutonnet Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ def read(fname):
'isodate>=0.6,<0.7',
'json-rpc>=1.12,<2',
'werkzeug>=0.15,<2.0',
'dataclasses==0.6;python_version<"3.7"',
'hologram==0.0.13',
'dataclasses==0.7;python_version<"3.7"',
Copy link
Contributor Author

@bastienboutonnet bastienboutonnet Mar 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also actually I'm not sure if we should pin strictly to 0.7 here or let it be like the hologram depenency which is >=0.6,<0.9

I gravitate towards the latter otherwise we're not really solving the issue of having too strict dependencies, what do you think @gshank ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with having this match the hologram dependency exactly: 'dataclasses>=0.6,<0.9;python_version<"3.7"' feels right.

'hologram==0.0.14',
'logbook>=1.5,<1.6',
'mashumaro==2.0',
'typing-extensions>=3.7.4,<3.8',
Expand Down