Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt init: add gitignore, ignore pycache #3536

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jul 6, 2021

Follow-up to #3474, #3483

Description

  • Exclude __pycache__ (if present, as it is for me) from dbt init
  • Include .gitignore for starter dbt projects

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@jtcohen6 jtcohen6 requested a review from leahwicz July 6, 2021 13:29
@cla-bot cla-bot bot added the cla:yes label Jul 6, 2021
@jtcohen6 jtcohen6 temporarily deployed to Postgres July 6, 2021 13:35 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift July 6, 2021 13:35 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift July 6, 2021 13:35 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery July 6, 2021 13:35 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery July 6, 2021 13:35 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake July 6, 2021 13:35 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake July 6, 2021 13:35 Inactive
@leahwicz
Copy link
Contributor

leahwicz commented Jul 6, 2021

I think .gitignore needs to be added to the Manifest.in file as well for the cases where we don't have the source code and this is packaged up. It needs to know to include those files

@jtcohen6 jtcohen6 force-pushed the fix/dbt-init-gitignore branch from d76addc to 5d6c507 Compare July 6, 2021 14:32
@jtcohen6 jtcohen6 temporarily deployed to Postgres July 6, 2021 14:39 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery July 6, 2021 14:39 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery July 6, 2021 14:39 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift July 6, 2021 14:39 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift July 6, 2021 14:39 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake July 6, 2021 14:39 Inactive
@jtcohen6 jtcohen6 merged commit 4906515 into develop Jul 6, 2021
@jtcohen6 jtcohen6 deleted the fix/dbt-init-gitignore branch July 6, 2021 15:51
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
automatic commit by git-black, original commits:
  4906515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants