Source freshness task node selection and cli command parity #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwigley
changed the title
kwigley
requested review from
jtcohen6,
a team,
nathaniel-may and
iknox-fa
and removed request for
a team
nathaniel-may
approved these changes
Jul 13, 2021
| @@ -137,11 +137,10 @@ def raise_on_first_error(self): | |||
| return False | |||
|
|
|||
| def get_selection_spec(self) -> SelectionSpec: | |||
There was a problem hiding this comment.
This is kind of non-obvious what's happening here. A comment could be useful.
kwigley
force-pushed
the
feature/source-freshness-parity
branch
from
d0512eb to
ebb5720
Compare
added 6 commits
July 20, 2021 13:45
kwigley
force-pushed
the
feature/source-freshness-parity
branch
from
ebb5720 to
56b1436
Compare
9 tasks
4 tasks
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* cli: add selection args for source freshness command * rename command to `source freshness` and maintain alias to old command * update and add tests for source freshness command and node selection * update changelog, add comments * fix formatting * update changelog automatic commit by git-black, original commits: 3dd486d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2987
Description
--select,--exclude,--selector)dbt source freshness --select raw_payments->dbt source freshness --select source:raw_paymentssource freshnesssource snapshot-freshnessvia cli and rpcNote: There is no deprecation warning for using the old command name, it wasn't as simple as I initially thought (#3565)
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.