-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update agate requirement from <1.6.2,>=1.6 to >=1.6,<1.6.4 in /core #3585
Conversation
bfbc28f
to
b052d63
Compare
@dependabot rebase |
Looks like this PR is already up-to-date with develop! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
We should double-check before merging this one: |
edde10d
to
9a15323
Compare
8c25482
to
7443e4c
Compare
@dependabot rebase |
Updates the requirements on [agate](https://github.com/wireservice/agate) to permit the latest version. - [Release notes](https://github.com/wireservice/agate/releases) - [Changelog](https://github.com/wireservice/agate/blob/master/CHANGELOG.rst) - [Commits](wireservice/agate@1.6.0...1.6.3) --- updated-dependencies: - dependency-name: agate dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
7443e4c
to
4663283
Compare
Paraphrasing from #3413 (comment), the two issues in
So I think we could go ahead with this upgrade, assuming the tests still pass. We should keep the pin very tight given the history of changes included in patch releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After synchronous discussion, we're good to move ahead with this
…3585) Updates the requirements on [agate](https://github.com/wireservice/agate) to permit the latest version. - [Release notes](https://github.com/wireservice/agate/releases) - [Changelog](https://github.com/wireservice/agate/blob/master/CHANGELOG.rst) - [Commits](wireservice/agate@1.6.0...1.6.3) --- updated-dependencies: - dependency-name: agate dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> automatic commit by git-black, original commits: f8cefa3
Updates the requirements on agate to permit the latest version.
Changelog
Sourced from agate's changelog.
... (truncated)
Commits
dc0684a
build: Iterate the version number9f3808b
test: Skip test that inexplicably fails intermittently on Linux on Python 3ca66f71
chore: Make charts.py executable091957b
chore: check-manifest4847a18
chore: isort, add pre-commit configuration to avoid such issues436444c
chore: Remove outdated comment01cdc12
test: Fix sys.version_info comparisona24ea5f
test: Skip test that inexplicably fails on Linux on Python 3.6daa04be
chore: flake8b4f7b71
test: Expand test failure message for debuggingYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)