-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Performance Regression Testing [Rust] #3602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahwicz
reviewed
Jul 20, 2021
leahwicz
reviewed
Jul 20, 2021
leahwicz
reviewed
Jul 20, 2021
This was referenced Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3054
Description
Adds the first iteration of performance regression testing. The test suite consists of the following components:
These tests will run nightly via github actions, and can be triggered through the UI. They will run all of these commands on all of the dbt projects with dbt installed from develop and with dbt installed from our baseline branch which is currently set to
0.20.latest
. It will trigger a failure if the dev branch is slower than the baseline version by a set threshold. Failures could be reported via email, slack and whatever else we think of.This PR is the first to include Rust in this repo. However, you can rest assured that contributors do not need to install the rust tool chain to continue contributing to dbt. this code relies on dbt, not the other way around.
This PR Is to be merged with the dummy projects. The regressions it is catching now are likely due to the fact the dummy projects do not induce any stress on dbt and thus have pretty high variance in their run times. Immediately after, I will put up a PR with at least one real project that may have thousands of files, but no other changes. From there the exact threshold numbers may still need to be tuned, but the variance in run times should be far more reasonable.
Suggested Path to Review this PR:
.github/workflows/performance.yml
. This is the highest level orchestration of the tests and outlines the workflow of how we are conducting these regression testsperformance/runner/src/main.rs
. This is the entry point to the rust runner that we saw in the github action. It has two sub commandsmeasure
andcalculate
. First look at the exit criteria here before moving on to the implementation of these sub commands.performance/runner/src/measure.rs::measure
since this is the entry point for the sub-command that is called first in the workflow.performance/runner/src/calculate.rs::regressions
since this is the entry point for the other sub-command.Requested Feedback
TODO:
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.