Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Retry GitHub download failures (#3729) #3798

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

leahwicz
Copy link
Contributor

@leahwicz leahwicz commented Aug 24, 2021

Backporting #3729

@jtcohen6 I forgot the changelog entry so I'll add that and port that too in another PR

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

* Retry GitHub download failures

* Refactor and add tests

* Fixed linting and added comment

* Fixing unit test assertRaises

Co-authored-by: Kyle Wigley <kyle@fishtownanalytics.com>

* Fixing casing

Co-authored-by: Kyle Wigley <kyle@fishtownanalytics.com>

* Changing to use partial for function calls

Co-authored-by: Kyle Wigley <kyle@fishtownanalytics.com>
@leahwicz leahwicz requested a review from jtcohen6 August 24, 2021 17:39
@leahwicz leahwicz temporarily deployed to Snowflake August 24, 2021 17:39 Inactive
@cla-bot cla-bot bot added the cla:yes label Aug 24, 2021
@leahwicz leahwicz temporarily deployed to Snowflake August 24, 2021 17:39 Inactive
@leahwicz leahwicz temporarily deployed to Postgres August 24, 2021 17:39 Inactive
@leahwicz leahwicz temporarily deployed to Redshift August 24, 2021 17:39 Inactive
@leahwicz leahwicz temporarily deployed to Redshift August 24, 2021 17:39 Inactive
@leahwicz leahwicz temporarily deployed to Bigquery August 24, 2021 17:39 Inactive
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this!

I suppose you could add a changelog entry for this go-round, and we'll make sure it gets in during the upcoming merge between 0.21.latest and develop

@leahwicz leahwicz closed this Aug 27, 2021
@leahwicz leahwicz reopened this Aug 27, 2021
@leahwicz leahwicz merged commit 34cec7c into 0.21.latest Aug 27, 2021
@leahwicz leahwicz deleted the leahwicz/backport3729 branch August 27, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants