[Backport] #3716 to v0.20.2, too #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahwicz
approved these changes
Aug 25, 2021
* Use is_relational check for schema caching * Fix flake8 * Update changelog
kwigley
force-pushed
the
backport-3716-to-020
branch
from
75baf6f to
57d0e21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As initially reported, #3715 was a cosmetic issue that resulted in some failed Snowflake queries, but no failed dbt runs. I've now heard reports from some users of other databases that don't have handling when dbt tries to cache (grab metadata for) a nonexistent schema (main Slack thread here).
This is definitely a fix for something v0.20-related. Now that I understand the bug is functional, not just cosmetic, I think it belongs in v0.20.2. The question if whether we'd want some extra testing and validation before final release—i.e. a second release candidate, v0.20.2-rc2, now that we've got a handful of changes since the last one.