-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests #3953
Fix integration tests #3953
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @kadero |
CLA signed ✔️ |
Closing and reopening to trigger adapter tests |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadero Thanks for this! There must have been something else going on in the previous issue (perhaps a non-UTC timestamp setting in Postgres?).
Since this is just a change to the integration test, this doesn't require a changelog entry, but if you're up for it, I'd still encourage you to add yourself to the list of Contributors there.
Yes probably, I not 100% sure of the root cause in the previous issue 😕
Done under Many thanks for your assist @jtcohen6 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @kadero! I just bumped up your contributor note to be under 1.0.0 :)
resolves #3952
Description
This PR aims to handle properly the datetime column in the integration test
TestSnapshotHardDelete.test__postgres__snapshot_hard_delete
.The timestamp we extract from PG is in
UTC
andoffset naive
. We just need to make itoffset aware
to enable the comparaison.astimezone(pytz.UTC)
to.replace(tzinfo=pytz.UTC)
The fix was tested locally by launching the test under multiple Timezone:
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.