Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mc knight 42/update contributing #3974

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Sep 29, 2021

…pelines to Github Actions for CI testing.

resolves #https://github.com/dbt-labs/core-team/issues/29

Description

  • Updated Contribute.MD to reflect swap over from CircleCI and Azure Pipelines to Github Actions.
  • Made Changes to reflect Removal of Adapaters from dbt-core repo to own repos
  • Added link and message to convey that Adapter specific issues/contributions should be made on their repos not the core repo.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented Sep 29, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Matthew McKnight.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@McKnight-42
Copy link
Contributor Author

@cla-bot check

@McKnight-42 McKnight-42 force-pushed the McKnight-42/update-contributing branch from 3d0c79a to 3a6b6ff Compare September 29, 2021 17:46
@McKnight-42 McKnight-42 force-pushed the McKnight-42/update-contributing branch from 3a6b6ff to ff4e521 Compare September 29, 2021 18:30
@cla-bot cla-bot bot added the cla:yes label Sep 29, 2021
@dbt-labs dbt-labs deleted a comment from cla-bot bot Sep 29, 2021
@dbt-labs dbt-labs deleted a comment from cla-bot bot Sep 29, 2021
@dbt-labs dbt-labs deleted a comment from cla-bot bot Sep 29, 2021
Copy link
Contributor

@kwigley kwigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @McKnight-42! I left one suggestion. After addressing, feel free to merge without waiting for another review.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com>
@McKnight-42 McKnight-42 merged commit b65ae1d into develop Sep 30, 2021
@McKnight-42 McKnight-42 deleted the McKnight-42/update-contributing branch September 30, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants