Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed error_id typo and added associated tests #4070

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 15, 2021

resolves #4051

Description

  • fixed bug where error_id existed instead of error_if
  • added tests around error_if
  • removed extra alias check

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Oct 15, 2021
@emmyoop
Copy link
Member Author

emmyoop commented Oct 15, 2021

Will need to be backported to 0.21.latest

@emmyoop emmyoop requested review from gshank, jtcohen6 and leahwicz and removed request for gshank October 15, 2021 15:56
@emmyoop emmyoop merged commit 4307a82 into main Oct 15, 2021
@emmyoop emmyoop deleted the er/4051-error-if branch October 15, 2021 18:22
emmyoop added a commit that referenced this pull request Oct 15, 2021
* fixed error_id typo and added tests

* added changelog entry
# Conflicts:
#	CHANGELOG.md
@emmyoop emmyoop mentioned this pull request Oct 15, 2021
4 tasks
emmyoop added a commit that referenced this pull request Oct 15, 2021
* fixed error_id typo and added tests

* added changelog entry
# Conflicts:
#	CHANGELOG.md
emmyoop added a commit that referenced this pull request Oct 22, 2021
* fixed error_id typo and added associated tests (#4070)

* fixed error_id typo and added tests

* added changelog entry
# Conflicts:
#	CHANGELOG.md

* removed strict flag to prevent warnings from erroring

* removed strict flag to prevent warnings from erroring
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* fixed error_id typo and added tests

* added changelog entry

automatic commit by git-black, original commits:
  4307a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] test not_null: error_if not working
3 participants