Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project name to default search packages #4114

Merged
merged 10 commits into from
Oct 22, 2021
Merged

Add project name to default search packages #4114

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bd62894
Add project name to default search packages
JCZuurmond Oct 22, 2021
8195adb
Add change to change log
JCZuurmond Oct 22, 2021
6eb433f
Use project_name instead of project
JCZuurmond Oct 22, 2021
2544741
Raise compilation error if no macros are found
JCZuurmond Oct 22, 2021
e85c2c7
Update change log line
JCZuurmond Oct 22, 2021
ed7acbb
Add test for package macro override
JCZuurmond Oct 22, 2021
fe50126
Add JCZuurmond to contributor
JCZuurmond Oct 22, 2021
396868b
Fix typos
JCZuurmond Oct 22, 2021
8bc2870
Add test that should not over ride the package
JCZuurmond Oct 22, 2021
4f5690b
Add doc string to tests
JCZuurmond Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- Make finding disabled nodes more consistent ([#4069](https://github.com/dbt-labs/dbt-core/issues/4069), [#4073](https://github.com/dbt-labas/dbt-core/pull/4073))
- Remove connection from `render_with_context` during parsing, thereby removing misleading log message ([#3137](https://github.com/dbt-labs/dbt-core/issues/3137), [#4062](https://github.com/dbt-labas/dbt-core/pull/4062))
- Wait for postgres docker container to be ready in `setup_db.sh`. ([#3876](https://github.com/dbt-labs/dbt-core/issues/3876), [#3908](https://github.com/dbt-labs/dbt-core/pull/3908))
- Prefer local macros over the ones in a package ([#4106](https://github.com/dbt-labs/dbt-core/issues/4106), [#4114](https://github.com/dbt-labs/dbt-core/pull/4114))

Contributors:
- [@sungchun12](https://github.com/sungchun12) ([#4017](https://github.com/dbt-labs/dbt/pull/4017))
Expand Down
2 changes: 1 addition & 1 deletion core/dbt/context/providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def dispatch(
elif isinstance(namespace, str):
search_packages = self._adapter.config.get_macro_search_order(namespace)
if not search_packages and namespace in self._adapter.config.dependencies:
search_packages = [namespace]
search_packages = [self.config.project, namespace]
JCZuurmond marked this conversation as resolved.
Show resolved Hide resolved
else:
# Not a string and not None so must be a list
raise CompilationException(
Expand Down