[Backport] #4114 #4117
[Backport] #4114 #4117
Conversation
* Add project name to default search packages We prefer macros in the project over the ones in the namespace (package) * Add change to change log * Use project_name instead of project * Raise compilation error if no macros are found * Update change log line * Add test for package macro override * Add JCZuurmond to contributor * Fix typos * Add test that should not over ride the package * Add doc string to tests
|
@jtcohen6 does this seem backport worthy? It doesn't seem like a bug or regression |
|
@leahwicz This was technically a regression in behavior from v0.20, reported in both #4029 + #4098. In v0.21.0, users are no longer able to override the adapter-specific implementations of built-in macros in the simple way they had previously. There are two easy workarounds for it (remove the adapter prefix, or add a We ended up figuring out a "win-win" way to restore the previous behavior by default, which is why I think we should backport. Users upgrading from v0.20.latest to v0.21.latest will now have their existing code "just work", no workaround needed, while still gaining access to the net-new functionality in v0.21 (to which the regression was related). |
No description provided.