-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbt init profile_template.yml improvements #4118
dbt init profile_template.yml improvements #4118
Conversation
@@ -63,7 +62,7 @@ def copy_starter_repo(self, project_name): | |||
def create_profiles_dir(self, profiles_dir: str) -> bool: | |||
"""Create the user's profiles directory if it doesn't already exist.""" | |||
profiles_path = Path(profiles_dir) | |||
if profiles_path.exists(): | |||
if not profiles_path.exists(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it, I'm all about it
Especially cool is that you can define profile_template.yml
for your project, even if your adapter plugin has not yet defined the defaults. Of course, it's super easy if you can just copy-paste the plugin defaults, and change prompts
into fixed
* Update profile_template.yml to use same syntax as target_options.yml * Rename target_options to profile_template * Update profile_template config spec automatic commit by git-black, original commits: 3397bdc
Follow up to #3625
to