Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clears adapters before registering to fix dbt-server cacheing behavior #4218

Merged
merged 4 commits into from
Nov 8, 2021

Conversation

racheldaniel
Copy link
Contributor

@racheldaniel racheldaniel commented Nov 5, 2021

resolves #TIGER-28

Description

In implementing dbt deps logic in the new client/server, it became clear that running deps in the server results in cacheing of adapters-- such that the server needed to be stopped if additional packages needed to be added. This PR resets adapters in dbt.lib.get_dbt_config before registration.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot
Copy link

cla-bot bot commented Nov 5, 2021

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @racheldaniel

@racheldaniel racheldaniel requested a review from kwigley November 5, 2021 20:33
@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 5, 2021

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Nov 5, 2021
@cla-bot
Copy link

cla-bot bot commented Nov 5, 2021

The cla-bot has been summoned, and re-checked this pull request!

@racheldaniel racheldaniel marked this pull request as ready for review November 8, 2021 14:33
@kwigley kwigley merged commit 229e897 into main Nov 8, 2021
@kwigley kwigley deleted the racheld/clear-adapters-before-registering-in-lib branch November 8, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants