Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get prerelease packages when specifically requested #4295

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

joellabes
Copy link
Contributor

resolves #4243

Description

Trying to install a prerelease version of dbt utils without the install-prerelease: True setting, e.g:

packages:
  - package: dbt-labs/dbt_utils
    version: 0.7.4-b1 

fails. Requesting a prerelease package by name should be enough to trigger its installation.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Nov 17, 2021
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! good to go with a changelog entry

@jtcohen6 jtcohen6 merged commit 0aacd99 into main Nov 18, 2021
@jtcohen6 jtcohen6 deleted the feat/4243-prerelease-package-by-request branch November 18, 2021 08:11
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* Get prerelease packages when specifically required. Add test validating it works

* Update CHANGELOG.md

automatic commit by git-black, original commits:
  0aacd99
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* Get prerelease packages when specifically required. Add test validating it works

* Update CHANGELOG.md

automatic commit by git-black, original commits:
  0aacd99
  52ec790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] An explicitly specified prerelease package should install without requiring install-prerelease
2 participants