Add windows OS error suppressing for temp dir cleanups #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-may
approved these changes
Dec 1, 2021
leahwicz
approved these changes
Dec 1, 2021
|
Good catch! |
yeppers |
leahwicz
pushed a commit
that referenced
this pull request
Dec 2, 2021
1 task
4 tasks
leahwicz
added a commit
that referenced
this pull request
Dec 2, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves # 4261
Description
Our new logging keeps files open in such a way that causes a problem for a test when executed in a windows-based env. It's apparently "a thing" involving the builtin
tempfile::TemporaryDirectoryand has a work-around in python 3.10. This PR replicates that behavior for all python versions we support.Checklist
CHANGELOG.mdand added information about my change