-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dbt docs overview to working url #4442
Fix dbt docs overview to working url #4442
Conversation
@remoyson thanks for submitting a fix for this and welcome to the community! I know this is a small update but would you mind updating the
I've also submitted a fix via #951 so that older versions of our docs won't have broken links. |
On more small thing - Since this is a small change to a link it's fine this time but in the future we like to have issues created before PRs. |
@emmyoop Thanks for the feedback! yes happy also to add it to the changelog :) |
@remoyson not a stupid question at all! It does indeed fix it but I would really prefer the link be right going forward so we don't have to have redirects everywhere! |
- Fix wrong url in the dbt docs overview homepage ([#4442](https://github.com/dbt-labs/dbt-core/pull/4442)) | ||
|
||
Contributors: | ||
- [remoyson](https://github.com/remoyson) ([#4442](https://github.com/dbt-labs/dbt-core/pull/4442)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Looks great. I'll go ahead and merge it in.
* Fix to working url * add fix to changelog
This PR fixes the default overview startup page of the docs pointing to an url that is not working anymore.
Checklist
CHANGELOG.md
and added information about my change