Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbt docs overview to working url #4442

Merged

Conversation

remoyson
Copy link
Contributor

@remoyson remoyson commented Dec 6, 2021

This PR fixes the default overview startup page of the docs pointing to an url that is not working anymore.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Dec 6, 2021
@emmyoop emmyoop assigned emmyoop and unassigned emmyoop Dec 8, 2021
@emmyoop emmyoop self-requested a review December 8, 2021 14:22
@emmyoop
Copy link
Member

emmyoop commented Dec 8, 2021

@remoyson thanks for submitting a fix for this and welcome to the community! I know this is a small update but would you mind updating the CHANGELOG.md with your change too? We love giving credit to everyone that helps make dbt what it is today! It looks like there isn't a new section yet for the next version so at the top of the file you would need to add the following:

## dbt-core 1.0.1 (TBD)

### Fixes
- 

Contributors:
- 

I've also submitted a fix via #951 so that older versions of our docs won't have broken links.

@emmyoop
Copy link
Member

emmyoop commented Dec 8, 2021

On more small thing - Since this is a small change to a link it's fine this time but in the future we like to have issues created before PRs.

@remoyson
Copy link
Contributor Author

remoyson commented Dec 8, 2021

@emmyoop Thanks for the feedback! yes happy also to add it to the changelog :)
Maybe stupid question but as you added it in the redirect won't that solve it as well and is this change in url here not really needed anymore as it redirects to a the working url? Or will the docs site also change for version 1.x.x?

@emmyoop
Copy link
Member

emmyoop commented Dec 8, 2021

@remoyson not a stupid question at all! It does indeed fix it but I would really prefer the link be right going forward so we don't have to have redirects everywhere!

- Fix wrong url in the dbt docs overview homepage ([#4442](https://github.com/dbt-labs/dbt-core/pull/4442))

Contributors:
- [remoyson](https://github.com/remoyson) ([#4442](https://github.com/dbt-labs/dbt-core/pull/4442))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Looks great. I'll go ahead and merge it in.

@emmyoop emmyoop merged commit b6811da into dbt-labs:main Dec 8, 2021
emmyoop pushed a commit that referenced this pull request Dec 8, 2021
* Fix to working url

* add fix to changelog
@emmyoop emmyoop mentioned this pull request Dec 8, 2021
emmyoop added a commit that referenced this pull request Dec 8, 2021
* Fix to working url

* add fix to changelog

Co-authored-by: Rebekka Moyson <remoyson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants