Deduplicate postgres relations (#3058) #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
added
the
Team:Adapters
McKnight-42
approved these changes
Feb 14, 2022
|
@netbek reviewed, would like you to go ahead and update to the newest version of main to make sure you have our implementation of the black formatter so those tests can run properly as well if you don't mind. and add your addition to the changelog |
|
@McKnight-42 Thanks for looking at it. I've merged in the most recent main and added a note to the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3058
Description
Removes duplicate dependencies in order to speed up
postgres_get_relationsquery. I've tested in Postgres 14 with a newly restored database and a basic dbt model (view materialization) that hadn't been materialized yet. I randbt docs generateand checked the log timestamps to confirm that the slowdown was caused by this query. The relations consist of 3 views and 11 tables in the same schema. Without the fix applied, 82 rows are returned and it takes ~16 s. With the fix applied, 14 rows are returned and it takes ~80 ms. Best of 3 runs. I removed the GROUP BY clause from the primary query to check this.I'm not able to share this database. Regardless, I think it would be too complicated for a test.
Checklist
CHANGELOG.mdand added information about my change