Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context for hook errors #478

Merged
merged 2 commits into from
Jul 6, 2017
Merged

context for hook errors #478

merged 2 commits into from
Jul 6, 2017

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Jul 4, 2017

This now looks like:

Found 3 models, 3 tests, 2 archives, 1 analyses, 14 macros, 2 operations

Database error while running on-run-start
Encountered an error:
schema "badschema" does not exist
LINE 1: create table if not exists badschema.prehook_test (id int)
                                   ^

For #456

@drewbanin drewbanin added this to the 0.8.3 milestone Jul 4, 2017
@drewbanin drewbanin requested a review from cmcarthur July 4, 2017 14:58
@cmcarthur
Copy link
Member

@drewbanin can you send me the reproducing case? 0.8.4 handles hooks differently

@drewbanin
Copy link
Contributor Author

@cmcarthur sure -- just write any on-run-start or on-run-end hook w/ a SQL error in it. I was using:

on-run-start: 'create table if not exists not_a_real_schema.test (id int)'
on-run-end: 'create table if not exists not_a_real_schema.test (id int)'

@drewbanin drewbanin merged commit 8634f9b into development Jul 6, 2017
@drewbanin drewbanin deleted the fix/errors-for-hooks branch July 6, 2017 15:20
@drewbanin drewbanin self-assigned this Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants