Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete CLI modeling for Click #5789

Merged
merged 11 commits into from
Sep 14, 2022
Merged

Conversation

iknox-fa
Copy link
Contributor

@iknox-fa iknox-fa commented Sep 8, 2022

resolves #5526

Description

New Click CLI that models the existing cli

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 8, 2022
@iknox-fa iknox-fa changed the title Iknox/ct 900 complete click modeling Complete CLI modeling for Click Sep 8, 2022
@iknox-fa iknox-fa marked this pull request as ready for review September 8, 2022 16:05
@iknox-fa iknox-fa requested a review from a team as a code owner September 8, 2022 16:06
core/setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1 @@
TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something stating where the things are defined?

@iknox-fa iknox-fa merged commit a096202 into main Sep 14, 2022
@iknox-fa iknox-fa deleted the iknox/CT-900-complete-click-modeling branch September 14, 2022 15:27
josephberni pushed a commit to Gousto/dbt-core that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-900] Complete CLI modeling (Top level API)
4 participants