Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI issue with tox #6137

Merged
merged 10 commits into from
Oct 25, 2022
Merged

Fix CI issue with tox #6137

merged 10 commits into from
Oct 25, 2022

Conversation

iknox-fa
Copy link
Contributor

See: #6134

eve-johns and others added 10 commits October 17, 2022 16:58
@eve-johns @leahwicz
f-string cleanup #6068 (#6082)
a9c8bc0 
* fix f string issue

* removed one space

* Add changelog

* fixed return format

Co-authored-by: Leah Antkiewicz <leah.antkiewicz@fishtownanalytics.com>
@luke-bassett
Updated string formatting on non-f-strings. (#6086)
35f7975 
* Updated string formatting on non-f-strings.

Found all cases of strings separated by white space on a single line and
removed white space separation. EX: "hello " "world" -> "hello world".

* add changelog entry
@VersusFacit
Working solution serialization bug. (#5874)
ff2f1f4 
* Create functors to initialize event types with str-type member attributes. Before this change, the spec of various classes expected base_msg and msg params to be str's. This assumption did not always hold true. post_init hooks ensures the spec is obeyed.
* Add new changelog.
* Add msg type change functor to a few other events that could use it.

Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
@VersusFacit
Add unit tests for recent stringifier functors added to events librar…
a7670a3 
…y. (#6095)

Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
@peterallenwebb
CT-1099: Migrate test 071_commented_yaml_regression_3568_tests (#6106)
53ae325
@MichelleArk
Add 'michelleark' to changie's core_team list (#6084)
6c86094
@MichelleArk
convert 027 cycle test (#6094)
17b8266 
* convert 027 cycle test

* remove no-op expect_pass=False

* remove postgres from test names
@iknox-fa
test if 2.9.4 works
d0c8119
@iknox-fa
test if upgrading pip helps
ba9e50d
@iknox-fa
2nd try fixing with updated pip
5969f3a
@iknox-fa iknox-fa added the Skip Changelog Skips GHA to check for changelog file label Oct 25, 2022
@iknox-fa iknox-fa requested a review from a team as a code owner October 25, 2022 18:06
@iknox-fa iknox-fa requested a review from a team October 25, 2022 18:06
@iknox-fa iknox-fa requested review from a team as code owners October 25, 2022 18:06
@cla-bot cla-bot bot added the cla:yes label Oct 25, 2022
stu-k
stu-k approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@stu-k stu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out 👍

@iknox-fa iknox-fa merged commit 5efc4aa into feature/click-cli Oct 25, 2022
@iknox-fa iknox-fa deleted the iknox/test-broken-psycopg2 branch October 25, 2022 18:32
This was referenced Jan 31, 2023
Merged
Closed
This was referenced Feb 8, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stu-k stu-k stu-k approved these changes

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may nathaniel-may was automatically assigned from dbt-labs/adapters

@gshank gshank Awaiting requested review from gshank gshank was automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@iknox-fa @ChenyuLInx @stu-k @eve-johns @luke-bassett @VersusFacit @peterallenwebb @MichelleArk