CT 1443 remove root path #6172
Merged
CT 1443 remove root path #6172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
emmyoop
requested changes
Oct 31, 2022
schemas/dbt/run-results/v4.json
Outdated
| @@ -37,12 +37,12 @@ | |||
| }, | |||
| "dbt_version": { | |||
| "type": "string", | |||
| "default": "1.2.0a1" | |||
| "default": "1.4.0a1" | |||
There was a problem hiding this comment.
It looks like only the default and description fields are changing. Do we really need to commit this?
schemas/dbt/manifest/v7.json
Outdated
Comment on lines
369
to
371
| "root_path": { | ||
| "type": "string" | ||
| }, |
There was a problem hiding this comment.
Do we need to bump the schema to v8 instead of modifying?
gshank
force-pushed
the
ct-1443-remove_root_path
branch
from
a5a4aa4 to
849523c
Compare
|
Yes, we did need to bump the schema to v8. Have done that work. |
emmyoop
requested changes
Nov 4, 2022
|
Yeah, I've removed that run-results file a couple of times and then I run the script again... Gone now, I hope. |
emmyoop
approved these changes
Nov 4, 2022
gshank
force-pushed
the
ct-1443-remove_root_path
branch
from
f178fab to
d83c734
Compare
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6171
Description
As part of cleanup for the structured logging effort, remove the 'root_path' field from most nodes.
Checklist
changie newto create a changelog entry