Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6191
Description
fire_event(DepsNotifyUpdatesAvailable(packages=packages_to_upgrade))
was previously passingpackages
as a list of strings which could not be serialized to the newListOfStrings
protobuf type during logging.dbt --log-format json deps
logged the following error event when installing a package that has an update available:Ideally mypy would have caught this issue but
DepsTask.run
was not scanned by mypy because the method signature did not have type annotations. After adding type annotations to theDepsTask.run
,mypy
was able to detect the issue (as well as a few others which are also addressed in this change):Checklist
changie new
to create a changelog entry