Example click API usage #6307
Merged
Example click API usage #6307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleArk
commented
Nov 23, 2022
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
MichelleArk
force-pushed
the
arky/example-dbt-client
branch
from
055fded to
69d9b04
Compare
ChenyuLInx
reviewed
Dec 7, 2022
core/dbt/docs/source/index.rst
Outdated
| dbt_cli.commands[command].invoke(ctx) | ||
|
|
||
|
|
||
| For the full code example, you can refer to `example.py <https://github.com/dbt-labs/dbt-core/blob/feature/click-cli/core/dbt/cli/example.py>`_ |
There was a problem hiding this comment.
I am not sure what would be a more clear way of add this type of link to a file that doesn't exists yet, or always keep it up to date
|
@MichelleArk I thinking of directly using this PR for #6099, hope you don't mind! |
ChenyuLInx
requested review from
ChenyuLInx and
stu-k
and removed request for
gshank and
colin-rogers-dbt
stu-k
reviewed
Dec 12, 2022
|
@iknox-fa this is updated with latest interface, and ready to review |
MichelleArk
commented
Jan 3, 2023
MichelleArk
force-pushed
the
arky/example-dbt-client
branch
from
2844c00 to
1257216
Compare
This was referenced Jan 31, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6310
resolves #6099
Description
This PR introduces a script that will serve as a base to be iterated on as we work through API-ification so that it serves as a live spec of the API-ified effort. Currently implemented with
depsbut ideally swapped out withrunas soon as that is available in the click API.Open Question(s)
Contextand invoking the relevant command. Should we provide a thin abstraction over this so callers don't need to be concerned with the details + extra dependency management of click?Checklist
changie newto create a changelog entry