-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile works w Click #6336
Profile works w Click #6336
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
448e401
to
9949d99
Compare
flags with user config, flags.WHICH from invoked_subcommand if available
d4bd1eb
to
ae77041
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for porting all of the changes together!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing stands out 👍
Moving all logic regarding constructing a complete UnsetProfile to this function | ||
This way we can have a clean load_profile function to call by the new CLI and remove | ||
all logic for UnsetProfile once we migrate to new click CLI | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just realized one thing, |
resolves #5536
Description
Allows the new CLick cli to access
Profile
s to pass in to various subcommands/tasks.Note: This PR breaks functional tests (new framework). The work to update that test framework is being handled in another ticket
Checklist
changie new
to create a changelog entry