Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBT_FAVOR_STATE_STATE -> DBT_FAVOR_STATE #6392

Merged
merged 2 commits into from
Jan 4, 2023
Merged

DBT_FAVOR_STATE_STATE -> DBT_FAVOR_STATE #6392

merged 2 commits into from
Jan 4, 2023

Conversation

NiallRees
Copy link
Contributor

Just noticed this while perusing #5859. I'll leave to the team to changelog and merge or close this PR for another :)

Description

Checklist

@NiallRees NiallRees requested review from a team and iknox-fa December 6, 2022 17:22
@cla-bot cla-bot bot added the cla:yes label Dec 6, 2022
@jtcohen6 jtcohen6 added ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering Team:Execution labels Dec 6, 2022
@jtcohen6
Copy link
Contributor

jtcohen6 commented Dec 6, 2022

Thanks @NiallRees, nice catch :)

@jtcohen6 jtcohen6 added this to the v1.4 milestone Dec 6, 2022
@ChenyuLInx ChenyuLInx requested a review from a team as a code owner January 4, 2023 22:11
@ChenyuLInx ChenyuLInx requested a review from emmyoop January 4, 2023 22:11
ChenyuLInx
ChenyuLInx approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NiallRees !!!

@ChenyuLInx ChenyuLInx merged commit 5453840 into dbt-labs:main Jan 4, 2023
@iknox-fa iknox-fa mentioned this pull request Jan 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@iknox-fa iknox-fa Awaiting requested review from iknox-fa

@emmyoop emmyoop Awaiting requested review from emmyoop emmyoop was automatically assigned from dbt-labs/core-group

Assignees

@ChenyuLInx ChenyuLInx

Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@NiallRees @jtcohen6 @ChenyuLInx