Click snapshot as click command (#5972) #6640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
ChenyuLInx
requested review from
iknox-fa,
MichelleArk,
stu-k and
aranke
and removed request for
peterallenwebb and
nathaniel-may
aranke
approved these changes
Jan 18, 2023
core/dbt/contracts/results.py
Outdated
| @@ -207,11 +207,15 @@ class RunExecutionResult( | |||
| generated_at: datetime = field(default_factory=datetime.utcnow) | |||
|
|
|||
| def write(self, path: str): | |||
| # just need shallow copy as we're not modifying content in dict | |||
There was a problem hiding this comment.
Should this be part of a separate PR?
core/dbt/contracts/results.py
Outdated
| @@ -207,11 +207,15 @@ class RunExecutionResult( | |||
| generated_at: datetime = field(default_factory=datetime.utcnow) | |||
|
|
|||
| def write(self, path: str): | |||
| # just need shallow copy as we're not modifying content in dict | |||
| args = self.args.copy() | |||
| args.pop("MP_CONTEXT", None) | |||
There was a problem hiding this comment.
Nit: use a list comprehension + lower to make this a bit cleaner.
This was referenced Jan 31, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5554
Description
tests/adapter/dbt/tests/adapter/grants/test_snapshot_grants.pynow runs fine and it invokes snapshot from dbtRunner on feature branchChecklist
changie newto create a changelog entry