Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbt build works in click #6680

Merged
merged 2 commits into from
Jan 20, 2023
Merged

dbt build works in click #6680

merged 2 commits into from
Jan 20, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jan 20, 2023 •
edited
Loading

resolves #5541

Description

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
    • picked changes from d76abdb locally and pytest tests/functional/build succeeds ✅
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@cla-bot cla-bot bot added the cla:yes label Jan 20, 2023
@MichelleArk MichelleArk changed the base branch from main to feature/click-cli January 20, 2023 01:55
@MichelleArk MichelleArk force-pushed the CT-917/build-with-click branch from dd307af to 50ed5c1 Compare January 20, 2023 01:57
@MichelleArk MichelleArk marked this pull request as ready for review January 20, 2023 02:01
@MichelleArk MichelleArk requested a review from a team as a code owner January 20, 2023 02:01
@MichelleArk MichelleArk requested review from nathaniel-may, stu-k, iknox-fa, ChenyuLInx and aranke and removed request for nathaniel-may January 20, 2023 02:01
ChenyuLInx
ChenyuLInx approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, having build test pass is great!

@MichelleArk MichelleArk merged commit 9823a56 into feature/click-cli Jan 20, 2023
@MichelleArk MichelleArk deleted the CT-917/build-with-click branch January 20, 2023 19:27
This was referenced Jan 31, 2023
Merged
Closed
This was referenced Feb 8, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@stu-k stu-k Awaiting requested review from stu-k stu-k was automatically assigned from dbt-labs/core-group

@iknox-fa iknox-fa Awaiting requested review from iknox-fa

@aranke aranke Awaiting requested review from aranke

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-917] dbt build works in click
2 participants
@MichelleArk @ChenyuLInx